OpenWrt/LEDE Project

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Base system
  • Assigned To No-one
  • Operating System All
  • Severity Low
  • Priority Very Low
  • Reported Version Trunk
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: OpenWrt/LEDE Project
Opened by Alex - 23.11.2018
Last edited by Petr Štetiar - 30.05.2019

FS#1965 - BT Home Hub 5A - 18.06 snapshots- Router crashes when the soft reset "Restart" key is pressed

BT HomeHub 5A
Latest snapshot dated Fri Nov 23 03:38:09 2018

After pressing the “Restart” button of the top left of the router, all LEDs go dark and the router becomes unresponsive.
Power Cycling the router will bring everything back up though.

Closed by  Petr Štetiar
30.05.2019 10:06
Reason for closing:  Fixed
Additional comments about closing:  

Fixed via https://github.com/openwrt/ openwrt/pull/2028

Alex commented on 25.11.2018 17:35

Update:
Well, this is a little awkward. Looking at the code, it seems that the “RESTART” key is and was always intended to execute ’ /sbin/poweroff’ just that executing ‘sbin/poweroff’ has never actually resulted in powering off / halting the router before and has always resulted in the router restarting. Why anyone would want to power the BTHOMEHUB V5 off using the big ass button, labeled "RESTART", on the top left of the unit, which is so easily deployed accidentally by a cat or subtle fluctuations in the earth’s gravitational field, when there is a perfectly decent off/on switch at the back, astounds me and leaves me wondering, have I been in the matrix all this time?
Anyways, my opinion is not what is important here and I have also seen many people who own different routers complaining bitterly that executing ‘sbin/poweroff’ does not HALT or power their units off. I will leave it to those who are more qualified to make those kinds of decisions as to whether it is correct or not. I have modified my version of the code so that, for me at least, the router continues to do what it was created to do... RUN.

Regards,
Alex

Alan Swanson commented on 04.04.2019 11:31

There aren't separate restart/reset button event codes so BTN_RESTART [0x198] had been multitasked to both restart and reset buttons. To prevent accidental (or malicious) factory resets, the following commit changed the restart button for Home Hub 5;
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=153b3f05d40aa558dfffdc617c0d0d285be26165

I assume you changed /etc/rc.button/power [package/base-files/files/etc/rc.button/power] to do a reboot preferably with a 5 second SEEN delay such as in /etc/rc.button/reset?

Might be useful to map a new button with corresponding rc.button entry with a 5 second SEEN delay till reboot for devices where a power off isn't useful. Perhaps KEY_POWER2 [0x164].

Alex commented on 25.04.2019 00:00

This is kinda old now but yes I redirected to reset with a short delay.

Faulty memory^^ and a little confusion between projects. It seems that in the end I simply reversed the commit you referred to.

TBH I have not used anything other than the code I last generated at the end of 2018 for any of my routers (currently 6) as I don't see any need to interfere with something that has been working solidly and I am happy with.
I have no idea what the latest code does but if the 'Restart' key still powers the router down, my opinion remains the same. A 'Restart' button IS handy but having this button power the router down when it is so easily pressed by accident or by a family pet is Trumpesque. There certainly should be some provision for maintaining the ORIGINAL function of any keys on this/any router when it is possible to do so.


Alan Swanson commented on 03.05.2019 14:08

Created pull request adding reboot button script to resolve;
https://github.com/openwrt/openwrt/pull/2028

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing