Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1885 - ath79 / WDR3600: disappeared WLAN5G LED control in kernel 4.14.74 #8060

Closed
openwrt-bot opened this issue Oct 8, 2018 · 2 comments
Labels

Comments

@openwrt-bot
Copy link

sz4bi:

device: TPLink WDR3600
platfrom: ath79

I do not know when it happened, in 4.14.63 it's OK, in 4.14.74 it is missing.

I have WLAN5G LED control under kernel 4.14.63

root@OpenWRT:~# uname -a
Linux OpenWRT 4.14.63 #0 Thu Aug 16 20:29:28 2018 mips GNU/Linux

root@OpenWRT:~# ls -al /sys/class/leds/
drwxr-xr-x 2 root root 0 Jan 1 1970 .
drwxr-xr-x 26 root root 0 Jan 1 1970 ..
lrwxrwxrwx 1 root root 0 Oct 8 18:03 ath9k-phy0 -> ../../devices/platform/ahb/ahb:apb/18100000.wmac/leds/ath9k-phy0
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:qss -> ../../devices/platform/leds/leds/tp-link:green:qss
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:system -> ../../devices/platform/leds/leds/tp-link:green:system
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:usb1 -> ../../devices/platform/leds/leds/tp-link:green:usb1
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:usb2 -> ../../devices/platform/leds/leds/tp-link:green:usb2
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:wlan2g -> ../../devices/platform/leds/leds/tp-link:green:wlan2g
lrwxrwxrwx 1 root root 0 Oct 8 18:03 tp-link:green:wlan5g -> ../../devices/platform/ath9k-leds/leds/tp-link:green:wlan5g

root@OpenWRT:~# ls -al /sys/devices/platform/leds/leds/
drwxr-xr-x 7 root root 0 Jan 1 1970 .
drwxr-xr-x 3 root root 0 Jan 1 1970 ..
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:qss
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:system
drwxr-xr-x 3 root root 0 Jan 1 1970 tp-link:green:usb1
drwxr-xr-x 3 root root 0 Jan 1 1970 tp-link:green:usb2
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:wlan2g

root@OpenWRT:~# ls -al /sys/devices/platform/ath9k-leds/leds/
drwxr-xr-x 3 root root 0 Oct 8 18:03 .
drwxr-xr-x 3 root root 0 Jan 1 1970 ..
drwxr-xr-x 2 root root 0 Oct 8 18:03 tp-link:green:wlan5g

But with kernel 4.14.74 it is missing

root@OpenWRT:~# uname -a
Linux OpenWRT 4.14.74 #0 Mon Oct 8 08:03:23 2018 mips GNU/Linux

root@OpenWRT:~# ls -al /sys/class/leds/
drwxr-xr-x 2 root root 0 Jan 1 1970 .
drwxr-xr-x 26 root root 0 Jan 1 1970 ..
lrwxrwxrwx 1 root root 0 Oct 8 18:07 ath9k-phy0 -> ../../devices/platform/ahb/ahb:apb/18100000.wmac/leds/ath9k-phy0
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:qss -> ../../devices/platform/leds/leds/tp-link:green:qss
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:system -> ../../devices/platform/leds/leds/tp-link:green:system
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:usb1 -> ../../devices/platform/leds/leds/tp-link:green:usb1
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:usb2 -> ../../devices/platform/leds/leds/tp-link:green:usb2
lrwxrwxrwx 1 root root 0 Jan 1 1970 tp-link:green:wlan2g -> ../../devices/platform/leds/leds/tp-link:green:wlan2g

root@OpenWRT:~# ls -al /sys/devices/platform/leds/leds/
drwxr-xr-x 7 root root 0 Jan 1 1970 .
drwxr-xr-x 3 root root 0 Jan 1 1970 ..
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:qss
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:system
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:usb1
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:usb2
drwxr-xr-x 2 root root 0 Jan 1 1970 tp-link:green:wlan2g

root@OpenWRT:~# ls -al /sys/devices/platform/ath9k-leds/leds
ls: /sys/devices/platform/ath9k-leds/leds: No such file or directory

root@OpenWRT:~# ls -al /sys/devices/platform/ath9k-leds/
drwxr-xr-x 2 root root 0 Jan 1 1970 .
drwxr-xr-x 13 root root 0 Jan 1 1970 ..
-rw-r--r-- 1 root root 4096 Oct 8 16:38 driver_override
-r--r--r-- 1 root root 4096 Oct 8 16:38 modalias
lrwxrwxrwx 1 root root 0 Oct 8 16:38 of_node -> ../../../firmware/devicetree/base/ath9k-leds
lrwxrwxrwx 1 root root 0 Oct 8 16:38 subsystem -> ../../../bus/platform
-rw-r--r-- 1 root root 4096 Oct 8 16:38 uevent

@openwrt-bot
Copy link
Author

hnyman:

ath9k LEDs have disappeared from ath79 two weeks ago due to commit ccab68f
"ath9k: fix unloading the module"

See discussion in https://forum.openwrt.org/t/is-anybody-working-on-linux-4-14-for-ar71xx-platform-porting-guide-to-ath79/13013/806

@openwrt-bot
Copy link
Author

sz4bi:

thanks for the heads up, btw what kind of problem is solved by this commit? why we want to unload the ath9k module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant