Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1802 - mt7620 32M flash using lede firmware can not reboot #7939

Closed
openwrt-bot opened this issue Aug 21, 2018 · 2 comments
Closed

FS#1802 - mt7620 32M flash using lede firmware can not reboot #7939

openwrt-bot opened this issue Aug 21, 2018 · 2 comments
Labels

Comments

@openwrt-bot
Copy link

louislu213:

Supply the following if possible:
After got the firmware using lede 17.01 version, the MT7628 can not reboot. i find some guides from the internet, and operated according the guide, but can not compile successfully.
The internet guide is as flowing:

static int m25p_remove(struct spi_device *spi)
{
struct m25p *flash = spi_get_drvdata(spi);

// manfeel note: add spi flash reset code
flash->command[0] = 0x66;
spi_write(flash->spi, flash->command, 1);
flash->command[0] = 0x99;
spi_write(flash->spi, flash->command, 1);
/* Clean up MTD stuff. */
return mtd_device_unregister(&flash->mtd);

}

static struct spi_driver m25p80_driver = {
.driver = {
.name = "m25p80",
.owner = THIS_MODULE,
},
.id_table = m25p_ids,
.probe = m25p_probe,
.remove = m25p_remove,
// manfeel, add shutdown method to reset spi flash
.shutdown = m25p_remove,

/* REVISIT: many of these chips have deep power-down modes, which
 * should clearly be entered on suspend() to minimize power use.
 * And also when they're otherwise idle...
 */

};

After i finished the changes, the compile can not pass:

there will be some error information, please check the attached picture:

-Werror incompatible pointer types,

it is very urgent for this case. hope you can help us as soon as possible!

thanks very much

@openwrt-bot
Copy link
Author

vortigont:

I'm running mt7620 with 32M SPI flash and works just fine. Which flash type you are using?

@openwrt-bot
Copy link
Author

ptpt52:

try this patch
x-wrt@62ad7b0
it should fix your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant