Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1399 - [gre] gre.sh has a non-declared dependency on resolveip #6353

Closed
openwrt-bot opened this issue Feb 28, 2018 · 1 comment
Closed
Labels

Comments

@openwrt-bot
Copy link

jeffsf:

Archer C7, "stock" 17.01.4
Packages installed include

  • kmod-gre
  • gre
  • ip-full

Able to manually create and use a gretap interface using ''ip'' from the command line

UCI configuration fails on
config interface 'gt_1'
option proto 'gretap'
option ipaddr '10.11.12.2'
option peeraddr '10.11.12.3'
option force_link '1'

with log entries of

daemon.notice netifd: gt_1 (25772): ./gre.sh: eval: line 1: resolveip: not found

This unit does not have a name server running on it, nor will it have access to one until the network is up.

''/lib/netifd/proto/gre.sh'' contains:
gre_setup() {
local cfg="$1"
local mode="$2"
local remoteip

    local ipaddr peeraddr
    json_get_vars df ipaddr peeraddr tunlink

    [ -z "$peeraddr" ] && {
            proto_notify_error "$cfg" "MISSING_PEER_ADDRESS"
            proto_block_restart "$cfg"
            exit
    }

    remoteip=$(resolveip -t 10 -4 "$peeraddr")

No dependency is on resolveip is given
# opkg info gre
Package: gre
Version: 1-7
Depends: libc
Status: install user installed
Architecture: mips_24kc
Installed-Time: 1519797112

Manually installing ''resolveip'' allows UCI configuration to complete.

Suggest either or both an explicit dependency on ''resolveip'' and "short-circuiting" the call if a string-literal IP address is supplied.

@openwrt-bot
Copy link
Author

jeffsf:

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant