Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1303 - Attended Sysupgrade: brcm2708 target hasn't been converted to use the new image generation code yet #6433

Closed
openwrt-bot opened this issue Jan 26, 2018 · 10 comments
Labels

Comments

@openwrt-bot
Copy link

tlaurion:

  • Device problem occurs on rpi3
  • LEDE Snapshot Attended Sysupgrade doesn't work since the image is not built with new image builder.

Steps to reproduce:

Error was previously posted openwrt/asu#88

@openwrt-bot
Copy link
Author

chunkeey:

Hm, too bad you closed the issue report.

"The true cause for this is that the brcm2708 target hasn't been converted to use the new image generation code yet. Take a look x86 or sunxi for examples of other block-device (ie. sdcard/emmc and such) platforms which already do that."

The brcm2708 target in master/trunk has been converted to use the new image generation code in trunk/master! This was done in patch:
[[https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=e79b096ee175219c072aeb8d228a07f3361c14ea|brcm2708: convert to metadata]]

That said, I tested the luci-app-attendedsysupgrade app on my Netgear WNDR3700v2 and got the same error message: "Unsupported device, release, target, subtraget or board".

@openwrt-bot
Copy link
Author

tlaurion:

Reopened [[https://github.com/openwrt/asu/issues/88]] with past comment

@openwrt-bot
Copy link
Author

tlaurion:

Feel free to comment original issue.

@openwrt-bot
Copy link
Author

aparcar:

The brcm2708 target in master/trunk has been converted to use the new image generation code in trunk/master! This was done in patch:

The sysupgrade only works with squashfs so the server complains as no squashfs image is found. Neither in the [[https://downloads.lede-project.org/snapshots/targets/brcm2708/bcm2708/|snapshots]].

Is there an easy way to add squashfs support for rpis or am I missing something?

The mentioned device should be supported, at least I receive a sysupgrade image in [[https://chef.libremesh.org/#906d6f1bd60b995|Chef IB]]. What release is installed on your device and can you check the contents of ubus call system board -> board_name? Maybe some [[https://github.com/aparcar/attendedsysupgrade-server/blob/master/distributions/lede/17.01.4.yml#L30|manual renaming]] is required :(

@openwrt-bot
Copy link
Author

tlaurion:

"kernel": "4.9.76",
"hostname": "OpenWrt",
"model": "Raspberry Pi 3 Model B Rev 1.2",
"board_name": "raspberrypi,3-model-b",
"release": {
	"distribution": "OpenWrt",
	"version": "SNAPSHOT",
	"revision": "r5952-cfdfa6d",
	"target": "brcm2708\/bcm2710",
	"description": "OpenWrt SNAPSHOT r5952-cfdfa6d"
}

@openwrt-bot
Copy link
Author

tlaurion:

Pointing to https://ledeupdate.planetexpress.cc/

Shows the following:
New firmware release available
SNAPSHOT to snapshot
Package upgrades available
kmod-usb-core: 4.9.76-1 to 4.9.77-1
odhcp6c: 2017-09-05-51733a6d-4 to 2017-09-05-1f93bd4c-5
kmod-pppoe: 4.9.76-1 to 4.9.77-1
kmod-nls-cp437: 4.9.76-1 to 4.9.77-1
fstools: 2018-01-02-11efbf3b-1 to 2018-01-13-18090d97-1
kmod-nls-utf8: 4.9.76-1 to 4.9.77-1
kmod-nf-nat: 4.9.76-1 to 4.9.77-1
kmod-hid-generic: 4.9.76-1 to 4.9.77-1
libxtables: 1.6.1-1 to 1.6.1-2
kmod-slhc: 4.9.76-1 to 4.9.77-1
libip4tc: 1.6.1-1 to 1.6.1-2
kmod-nf-conntrack6: 4.9.76-1 to 4.9.77-1
kmod-nf-conntrack: 4.9.76-1 to 4.9.77-1
procd: 2018-12-02-a5954cf3-2 to 2018-01-23-653629f1-2
libip6tc: 1.6.1-1 to 1.6.1-2
ubox: 2017-11-06-2c0d9cfe-1 to 2017-11-13-e7a63fba-1
kmod-nf-ipt: 4.9.76-1 to 4.9.77-1
kmod-usb-hid: 4.9.76-1 to 4.9.77-1
luci-app-attendedsysupgrade: git-18.012.27029-5248587-1 to git-18.030.59690-47d1eaa-1
kmod-hid: 4.9.76-1 to 4.9.77-1
kmod-brcmfmac: 4.9.76+2017-11-01-1 to 4.9.77+2017-11-01-3
kmod-nf-ipt6: 4.9.76-1 to 4.9.77-1
base-files: 184-r5952-cfdfa6d to 184-r5985-33e8f7e
kmod-brcmutil: 4.9.76+2017-11-01-1 to 4.9.77+2017-11-01-3
luci-theme-bootstrap: git-18.023.74248-ee409b6-1 to git-18.030.59690-47d1eaa-1
ip6tables: 1.6.1-1 to 1.6.1-2
kmod-input-core: 4.9.76-1 to 4.9.77-1
kmod-ipt-nat: 4.9.76-1 to 4.9.77-1
iptables: 1.6.1-1 to 1.6.1-2
kmod-lib-crc-ccitt: 4.9.76-1 to 4.9.77-1
kmod-ipt-core: 4.9.76-1 to 4.9.77-1
kmod-sound-arm-bcm2835: 4.9.76-1 to 4.9.77-1
kmod-fs-vfat: 4.9.76-1 to 4.9.77-1
kmod-ppp: 4.9.76-1 to 4.9.77-1
luci: git-18.012.27029-5248587-1 to git-18.030.59690-47d1eaa-1
iwinfo: 2017-08-23-c1a03e82-1 to 2018-01-16-5a5e21b1-1
kmod-nls-iso8859-1: 4.9.76-1 to 4.9.77-1
kmod-mmc: 4.9.76-1 to 4.9.77-1
ubus: 2017-11-13-5f87f548-1 to 2018-01-16-5bae22eb-1
kmod-rt2800-usb: 4.9.76+2017-11-01-1 to 4.9.77+2017-11-01-3
libubus: 2017-11-13-5f87f548-1 to 2018-01-16-5bae22eb-1
kmod-ipt-conntrack: 4.9.76-1 to 4.9.77-1
kmod-input-evdev: 4.9.76-1 to 4.9.77-1
kmod-cfg80211: 4.9.76+2017-11-01-1 to 4.9.77+2017-11-01-3
kmod-pppox: 4.9.76-1 to 4.9.77-1
kmod-sound-core: 4.9.76-1 to 4.9.77-1
kernel: 4.9.76-1-f1c690668b21139ca18b54e4238aeef6 to 4.9.77-1-c6ed93e30954a5ac73ce66e0d8932dd1
logd: 2017-11-06-2c0d9cfe-1 to 2017-11-13-e7a63fba-1
kmod-nls-base: 4.9.76-1 to 4.9.77-1
kmod-ip6tables: 4.9.76-1 to 4.9.77-1

And then hitting formware upgrade results in:
Unsupported device, release, target, subtraget or board

@openwrt-bot
Copy link
Author

chunkeey:

From what I can guess, there are currently two minor problems with attended-sysupgrade. Both should be easy to fix however

  1. extend the [[https://github.com/aparcar/attendedsysupgrade-server/blob/c8684b12d7a0b95222eec8aea20608d2595ce0ed/worker/worker.py#L209|worker.py]] to look for more image types.

The RPIs use *-ext4-sdcard.img.gz. But I think this could be extended to *.img.gz to get the APM821XX MyBook Live as well.

  1. The brcm27xx targets use multi-target images. So, the "board_name": "raspberrypi,3-model-b". needs to become "rpi-3". Luckily, it seems that the attended-sysupgrade project already has that infrastructure for this too.

[[https://github.com/aparcar/attendedsysupgrade-server/blob/e88bb84c7ff4f1e29fb0ffcf14bb5539e0895942/distributions/openwrt/snapshot.yml|snapshot.yml]]. So I guess adding a "raspberrypi,3-model-b: rpi-3" would do the trick?!

@openwrt-bot
Copy link
Author

tlaurion:

On referred github issue:

aparcar
commented 1 day ago

@tlaurion no, as I'm not the one that can push anything. The squasfs filesystem is upgradeable as it's stores files in an overlay filesystem while the current images uses ext4. Reflashing ext4 results in a total overwrite of all custom modified files and essentially resets your device - so not supported.
As far as I can tell it's possible to modify the build system that there are ext4 and squasfs files, see x86/64. However until that's not the case, it's unsupported :(

@openwrt-bot
Copy link
Author

chunkeey:

k, I just commented there as well.

@tlaurion, @aparcar what's the plan? Should the discussion be moved to github or stay here in the bugtracker? I really dislike switching between the two.

@openwrt-bot
Copy link
Author

mkresin:

closing this, as the brcm2708 target has been converted to use the new image generation code awhile ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant