fleskalebas:

The spaces in the label name are truncated above, in reality there are multiple spaces instead of just one.

john:

are you able to build your own image if i provide a test patch ?

fleskalebas:

Yes, no problem :)

john:

try this patch please

fleskalebas:

Thanks, end of this week I'm going to build a new image and report asap.

fleskalebas:

After applying the patch, no extra character appends in the LABEL name.

However, when I name the disk with a label shorter than 11 characters, block info still pads the label name with spaces until the name is 11 characters long. A label with exactly 11 characters will work to avoid spaces.

In the bug report I accidentally stated that the label name must be 12 characters. This is wrong, the max size of a fat32 label is 11 characters. However, the patch still works.

jow-:

Hm I guess that other implemenations right-trim the spaces from the label for convenience reasons. I do recall that FAT labels are sometimes displayed as "foo" and sometimes as "foo " by various tools and operating systems.

For maximal compatibility we likely should trim both user provided and blkid provided fat labels before working with them.

fleskalebas:

The use case for me is mounting by LABEL name instead of device name (since sda might sometimes become sdb) To ensure that it works, I use a 11-character name to avoid errors because of the spaces, but maybe the mounting ignores the spaces too, then it's all fixed by the patch.

mirko:

As a follow up - the following patch truncates the filesystem label and replaces the first occurrence of a blank (0x20) with a \0-byte:
https://pb.nanl.de/show.php?id=44995&hash=15878593