Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS#1257 - Node.JS stopped working on mipsel_24kc in trunk (requires FPU) #6245

Closed
openwrt-bot opened this issue Jan 5, 2018 · 3 comments
Closed

FS#1257 - Node.JS stopped working on mipsel_24kc in trunk (requires FPU) #6245

openwrt-bot opened this issue Jan 5, 2018 · 3 comments
Labels
flyspray

Comments

@openwrt-bot
Copy link

benVolatiles:

LEDE/OpenWRT provides builds of Node.js for MIPSel 24Kc that require floating point instructions, however MIPS 24Kc doesn't have a FPU. (only MIPS 24Kf does).

It still worked fine, at least on mt7688 with LEDE 17.01.4, as the kernel was configured with [[https://git.lede-project.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ramips/mt7688/config-4.4;h=5e35e23451af97fa4b9cfef3ac40ba46da05c5fa;hb=a92c64e8ae38f6a221823610c4a2f454c813c484#l126|FPU emulation enabled]].

This config option was dropped when moving to Linux 4.9 and merging mt7688 with mt7628 to mt76x8.
@openwrt-bot
Copy link
Author

benVolatiles:

It looks like it's possible to [[https://techfindings.one/archives/2064|configure node]] so that it [[https://github.com/nodejs/node/blob/master/deps/v8/gypfiles/toolchain.gypi#L55|doesn't use FPU instructions]].

Never mind, I should have read the article to the end. This used to work with Node.js v0.10.40, but with Node.js v4.1.2, this option stopped working apparently.

@openwrt-bot
Copy link
Author

yousong:

Hi, Benjamin, I opened a pull request [1] to let nodejs depend on symbol HAS_FPU. This will cause it won't be built for those targets lacking 'fpu' in their FEATURES enumeration.

If you'd like to propose enabling MIPS_FPU_EMULTATOR for mt76x8 again, please consider posting a patch to the mailing list with your arguments in the commit message. Thank you.

[1] openwrt/packages#5513

@openwrt-bot
Copy link
Author

yousong:

Hi, a new config option KERNEL_MIPS_FPU_EMULATOR was just added to the base build system. Kernel will have fpu emulator builtin after this option is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openwrt-bot