Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1213 - Lede-OpenWrt rebranding error: codename fields still in /etc/openwrt_release and /usr/lib/os-release #6163

Closed
openwrt-bot opened this issue Dec 9, 2017 · 0 comments
Labels

Comments

@openwrt-bot
Copy link

hnyman:

Rebranding of LEDE to OpenWrt is slightly incomplete.

The removed codename/nickname fields (both %n and %N) are used in /etc/openwrt_release file on items DISTRIB_CODENAME and DISTRIB_DESCRIPTION. (The latter one is used also LuCI, so the error gets visible easily) The same happens also in /usr/lib/os-release

Erroneous fields:

https://git.lede-project.org/?p=source.git;a=blob;f=package/base-files/files/etc/openwrt_release;hb=HEAD

DISTRIB_CODENAME='%n'
DISTRIB_DESCRIPTION='OpenWrt %N SNAPSHOT r5484-69d22a6bf6'

https://git.lede-project.org/?p=source.git;a=blob;f=package/base-files/files/usr/lib/os-release;hb=HEAD

VERSION="SNAPSHOT, %N"
PRETTY_NAME="OpenWrt %N SNAPSHOT"
LEDE_RELEASE="OpenWrt %N SNAPSHOT r5484-69d22a6bf6"

Full files in a live router:

root@router2:~# cat /etc/openwrt_release
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='SNAPSHOT'
DISTRIB_REVISION='r5484-69d22a6bf6'
DISTRIB_CODENAME='%n'
DISTRIB_TARGET='ar71xx/generic'
DISTRIB_ARCH='mips_24kc'
DISTRIB_DESCRIPTION='OpenWrt %N SNAPSHOT r5484-69d22a6bf6'
DISTRIB_TAINTS='no-all busybox'

root@router2:~# cat /usr/lib/os-release
NAME="OpenWrt"
VERSION="SNAPSHOT, %N"
ID="openwrt"
ID_LIKE="lede openwrt"
PRETTY_NAME="OpenWrt %N SNAPSHOT"
VERSION_ID="snapshot"
HOME_URL="http://lede-project.org/"
BUG_URL="http://bugs.lede-project.org/"
SUPPORT_URL="http://forum.lede-project.org/"
BUILD_ID="r5484-69d22a6bf6"
LEDE_BOARD="ar71xx/generic"
LEDE_ARCH="mips_24kc"
LEDE_TAINTS="no-all busybox"
LEDE_DEVICE_MANUFACTURER="OpenWrt"
LEDE_DEVICE_MANUFACTURER_URL="http://lede-project.org/"
LEDE_DEVICE_PRODUCT="Generic"
LEDE_DEVICE_REVISION="v0"
LEDE_RELEASE="OpenWrt %N SNAPSHOT r5484-69d22a6bf6"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant