Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1188 - odhcpd: make dhcpv4 compile configurable breaks optional install (fd80621fea5cafcdca3f7fe762fede374a #6130

Closed
openwrt-bot opened this issue Nov 22, 2017 · 3 comments
Labels

Comments

@openwrt-bot
Copy link

EricLuehrsen:

Problem: Commit in title breaks optional package installation on complete images with opkg. The default and only package of odhcpd is free of DHCPv4. This makes optional how-to, recipe, and other guides for alternate package use obsolete or fail all together. This commit is a rather dramatic change (remove content) without consideration for the use cases.

Use case: There are users of odhpcd as the only DHCP server in minimal builds for subnet router management only. There are users of odhcpd as the only DHCP server with BIND or Unbound and scripts to incorporate leases into the local DNS (instead of dnsmasq). Unbound is ready as an installable package with UCI/LuCI.

Note: these how-to and recipe are often intended for end users than will not or cannot build there own software from scratch. They expect releases to have the appropriate optional packages available through opkg.

Solution 1: Make odhcpd default build as complete as it has been. Improve UCI options to robustly enable/disable DHCPv4 or DHCPv6 to avoid the mentioned "conflicts" with other packages.

Solution 2: Ensure odhcpd-no-dhcpv4 and odhcpd-full are build bot available packages, so that end users of released LEDE/OpenWrt (17.04, 18.01, ...) have install packages available.

@openwrt-bot
Copy link
Author

EricLuehrsen:

There appears to be an error in DHCPv4 function when conditionally compiled on. Clients are unable to obtain DHCPv4 leases. I have not had time to investigate properly, but there appears to be a regression introduced.

@openwrt-bot
Copy link
Author

dedeckeh:

Report the observed DHCPv4 issue in a separate record as this is not related to the issue reported in this record.
Provide detailed info such as he dhcp config you're using and odhcpd traces by setting loglevel to 7.

@openwrt-bot
Copy link
Author

EricLuehrsen:

It seems that it was something happening in 'make' (w/ CMake) build avoidance... back to the ticket as originally written. Considering the use cases, should Solution 1, Solution 2, or another option be taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant