Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS#1182 - UCI incorrect implementation of anonymous uci section counter? #6191

Closed
openwrt-bot opened this issue Nov 22, 2017 · 0 comments
Closed

FS#1182 - UCI incorrect implementation of anonymous uci section counter? #6191

openwrt-bot opened this issue Nov 22, 2017 · 0 comments
Labels
flyspray

Comments

@openwrt-bot
Copy link

mondwan:

From the uci version 2017-09-29, below line seems is a problematic implementation.

https://git.lede-project.org/?p=project/uci.git;a=blob;f=list.c;h=321861c8eb7d741c17a1cc764e4e648635640b13;hb=5ad59ad412a784c5c478e31d1701ce39568ffd58#l178

It messy up the package counter n_section. As n_section has already be increased in [https://git.lede-project.org/?p=project/uci.git;a=blob;f=list.c;h=321861c8eb7d741c17a1cc764e4e648635640b13;hb=5ad59ad412a784c5c478e31d1701ce39568ffd58#l198].

Is there any reasons for using ++s->package->n_section instead of s->package->n_section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openwrt-bot