Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1121 - make image doesn't return failure if build fails #7983

Closed
openwrt-bot opened this issue Oct 28, 2017 · 0 comments
Closed

FS#1121 - make image doesn't return failure if build fails #7983

openwrt-bot opened this issue Oct 28, 2017 · 0 comments
Labels

Comments

@openwrt-bot
Copy link

brianjmurrell:

Supply the following if possible:

  • Device problem occurs on
    N/A

  • Software versions of LEDE release, packages, etc.
    17.01.4

  • Steps to reproduce
    Set up the imagebuilder and build an image with:

make -C $BUILDER_DIR/ image PROFILE="$PROFILE" PACKAGES="$PACKAGES" FILES="$PWD/$FILES_DIR" CUSTOMIZE_IMAGE_SCRIPT=$PWD/$ROUTER_MODEL.custom

Where $PACKAGES is a list big enough to make the image too big so that you get:

[mktplinkfw] *** error: images are too big by 1614 bytes

Observe that the exit status from the above make is still 0. That make should reflect that the build failed with a non-zero exit status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant