Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1030 - ubus call network reload fails with unknown error #5980

Closed
openwrt-bot opened this issue Oct 1, 2017 · 7 comments
Closed

FS#1030 - ubus call network reload fails with unknown error #5980

openwrt-bot opened this issue Oct 1, 2017 · 7 comments
Labels

Comments

@openwrt-bot
Copy link

val-kulkov:

"ubus call network reload" fails with "Command failed: Unknown error" on LEDE Reboot SNAPSHOT r4235-61eb18d. The same error message appears with:

"service network reload"
"/etc/init.d/network reload"

This issue is not present in LEDE Rebooot 17.01.2 r3435-65eec8bd5f.

@openwrt-bot
Copy link
Author

mkresin:

Works for me with Reboot (SNAPSHOT, r4960-1114f5d). r4235-61eb18d is from May 2017. You should really update to a recent version before reporting any bugs.

If the issue persist after installing a recent snapshot, please reopen the ticket and provide the following informations:

  • on which device does the problem occur?
  • does it happened as well if you reset your config to factory defaults?
  • please attach your /etc/config/network

@openwrt-bot
Copy link
Author

val-kulkov:

The same issue was also observed on the development shapshot build for the bcm53xx target. Sorry, I should have mentioned it in my original bug submission earlier today. The image I used for testing was downloaded on 2017-10-01 from:

http://downloads.lede-project.org/snapshots/targets/bcm53xx/generic/lede-bcm53xx-buffalo-wxr-1900dhp-squashfs.trx

The downloaded image was installed with "sysupgrade -v -n ./lede-bcm53xx-buffalo-wxr-1900dhp-squashfs.trx". I made no configuration changes in any of the files in /etc/config/ after installing the downloaded image.

I also tested this issue on my own LEDE build, LEDE Reboot SNAPSHOT r4967-5508510. The result was the same: "“Command failed: Unknown error".

@openwrt-bot
Copy link
Author

val-kulkov:

See my comment of 01.10.2017 18:36.

@openwrt-bot
Copy link
Author

jow-:

I can confirm the issue on the current x86_64 snapshot image.

root@LEDE:/# cat /etc/os-release
NAME="LEDE"
VERSION="SNAPSHOT, Reboot"
ID="lede"
ID_LIKE="lede openwrt"
PRETTY_NAME="LEDE Reboot SNAPSHOT"
VERSION_ID="snapshot"
HOME_URL="http://lede-project.org/"
BUG_URL="http://bugs.lede-project.org/"
SUPPORT_URL="http://forum.lede-project.org/"
BUILD_ID="r4960-1114f5d"
LEDE_BOARD="x86/64"
LEDE_ARCH="x86_64"
LEDE_TAINTS=""
LEDE_DEVICE_MANUFACTURER="LEDE"
LEDE_DEVICE_MANUFACTURER_URL="http://lede-project.org/"
LEDE_DEVICE_PRODUCT="Generic"
LEDE_DEVICE_REVISION="v0"
LEDE_RELEASE="LEDE Reboot SNAPSHOT r4960-1114f5d"
root@LEDE:/# ubus call network reload
Command failed: Unknown error
root@LEDE:/#

@openwrt-bot
Copy link
Author

val-kulkov:

If a device has no wireless interfaces, the uci config for the wireless will fail and netifd's config_init_all() function will return -1: https://git.lede-project.org/?p=project/netifd.git;a=blob;f=config.c;h=a7112f042a677426ab27baff8b8131e0bb4e3d40;hb=HEAD#l424

The return value of -1 then propagates to netifd_reload():
https://git.lede-project.org/?p=project/netifd.git;a=blob;f=main.c;h=c173cef35be5a840d1d9d5d3b67c3eeab3f0c3b0;hb=HEAD#l213

and then to netifd_handle_reload()
https://git.lede-project.org/?p=project/netifd.git;a=blob;f=ubus.c;h=bf7267239ccc7ab16625fc658f1a04cfcc015db7;hb=HEAD#l48

The suggested fix is to check for presence of /etc/config/wireless and return -1 only if the file is present.

@openwrt-bot
Copy link
Author

deepakpradhan5:

Hi,

I am also facing the same issue with ubus.
For me also "/etc/init.d/network reload" not working.
Further nail-down the issue and found "ubus call network reload" not working.

###iotGateway### ubus call network reload
Command failed: Unknown error

The below are my LEDE info:
VERSION="SNAPSHOT, Reboot"
VERSION_ID="snapshot"
HOME_URL="http://lede-project.org/"
BUG_URL="http://bugs.lede-project.org/"
SUPPORT_URL="http://forum.lede-project.org/"
BUILD_ID="r4795-c1563d7"
LEDE_BOARD="mediatek/32"
LEDE_ARCH="arm_cortex-a7_neon-vfpv4"
LEDE_TAINTS="no-all busybox"
LEDE_DEVICE_MANUFACTURER_URL="http://lede-project.org/"
LEDE_RELEASE="Reboot SNAPSHOT r4795-c1563d7"

Can anyone put light on this issue?
Can someone guide me which patch/code changes I have to integrate with my Lede code base to fix this issue?
Note: I have downloaded Lede code base from github and compiled for bananapi-r2 device.

@openwrt-bot
Copy link
Author

mkresin:

Update to the latest source!

You are using r4795, which should be from somewhat around Wed, 6 Sep 2017 14:46:03 +0100. This fix was committed on Fri, 6 Oct 2017 16:31:21 +0100 to netifd and netifd was updated in LEDE on Thu, 27 Oct 2016 11:45:05 +0100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant