Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3982 - Need rename "fallthrough" in libubox/utils.h to something other #8975

Open
openwrt-bot opened this issue Aug 18, 2021 · 0 comments
Labels
core packages pull request/issue for core (in-tree) packages flyspray

Comments

@openwrt-bot
Copy link

Azq2:

This define: https://lxr.openwrt.org/source/libubox/utils.h#L236
Conflicts with package "nlohmannjson"

Example:
In file included from Json.h:2,
from Ubus.h:11,
from ModemService.h:6,
from ModemService.cpp:1:
/openwrt/staging_dir/target-mipsel_24kc_musl/usr/include/nlohmann/json.hpp:1689:42: error: missing ')' after "__has_attribute"
JSON_HEDLEY_HAS_ATTRIBUTE(fallthrough) ||
^
/openwrt/staging_dir/target-mipsel_24kc_musl/usr/include/nlohmann/json.hpp:1689:31: error: missing binary operator before token "("
JSON_HEDLEY_HAS_ATTRIBUTE(fallthrough) ||
^~~~~~~~~~~
/openwrt/staging_dir/target-mipsel_24kc_musl/usr/include/nlohmann/json.hpp:1692:57: error: missing ')' after "__has_attribute"
#elif JSON_HEDLEY_HAS_CPP_ATTRIBUTE_NS(clang,fallthrough)
^
/openwrt/staging_dir/target-mipsel_24kc_musl/usr/include/nlohmann/json.hpp:1692:46: error: missing binary operator before token "("
#elif JSON_HEDLEY_HAS_CPP_ATTRIBUTE_NS(clang,fallthrough)
^~~~~~~~~~~
/openwrt/staging_dir/target-mipsel_24kc_musl/usr/include/nlohmann/json.hpp:1694:48: error: missing ')' after "__has_attribute"
#elif JSON_HEDLEY_HAS_CPP_ATTRIBUTE(fallthrough)
^
/openwrt/staging_dir/target-mipsel_24kc_musl/usr/include/nlohmann/json.hpp:1694:37: error: missing binary operator before token "("
#elif JSON_HEDLEY_HAS_CPP_ATTRIBUTE(fallthrough)

@aparcar aparcar added the core packages pull request/issue for core (in-tree) packages label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages flyspray
Projects
None yet
Development

No branches or pull requests

2 participants