Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#3613 - Overestimated entropy in urgnd #8644

Closed
openwrt-bot opened this issue Feb 9, 2021 · 2 comments
Closed

FS#3613 - Overestimated entropy in urgnd #8644

openwrt-bot opened this issue Feb 9, 2021 · 2 comments
Labels
core packages pull request/issue for core (in-tree) packages flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release

Comments

@openwrt-bot
Copy link

kroeckx:

I was looking at the entropy collected by the jitterentropy library that urngd is using. I've filed a bug against the library at smuellerDD/jitterentropy-library#21

What I'm seeing it that is overestimates the amount of entropy collected. On my desktop machine this is at least a factor of 100. I've not looked at any of my devices using OpenWRT yet, but I expect it to be worse there.

Urngd has an oversampling factor, which is currently set to 2, meaning the factor is 2 time smaller. The oversampling in urngd currently collects twice as many bytes (64), and then tells the kernel that it contains 32 byte / 256 bit of entropy. The library also supports oversampling itself, it's a parameter to the jent_entropy_collector_alloc function.

I suggest that you set the oversampling factor to at least 1000.

@aparcar aparcar added release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release core packages pull request/issue for core (in-tree) packages labels Feb 22, 2022
@ynezz
Copy link
Member

ynezz commented May 24, 2022

OpenWrt 19.07 release is EOL, try to reproduce the issue with latest supported release and feel free to ask for issue reopening if the problem is still present, thanks.

@ynezz ynezz closed this as completed May 24, 2022
@champtar
Copy link
Member

@kroeckx could you check this is still relevant ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release
Projects
None yet
Development

No branches or pull requests

4 participants